Allow packs to be created anywhere#130
Merged
ashleywillard merged 1 commit intorubyatscale:mainfrom Nov 28, 2023
Merged
Conversation
| ).returns(ParsePackwerk::Package) | ||
| end | ||
| def self.create_pack_if_not_exists!(pack_name:, enforce_privacy:, enforce_dependencies:, team: nil) | ||
| if PERMITTED_PACK_LOCATIONS.none? { |permitted_location| pack_name.start_with?(permitted_location) } |
Contributor
There was a problem hiding this comment.
@naveg Could we change this to check the packs config and ensure that the desired pack path is permitted via the configuration?
Contributor
Author
There was a problem hiding this comment.
That makes sense. I'll give it a go and update this PR
naveg
force-pushed
the
naveg/allowed-folders
branch
from
30af7ac to
96adbd9
Compare
Contributor
alexevanczuk
left a comment
alexevanczuk
left a comment
There was a problem hiding this comment.
Nice looks great! @shageman could you help get this merged?
Contributor
|
Thanks @naveg for the PR. My team is dedicating two working sessions each week to review open PRs. We've been using a two-prong approach to tackle the newest open PRs and the oldest open PRs during each session. |
ashleywillard
approved these changes
Nov 28, 2023
Contributor
Author
|
@professor makes sense - thanks! |
`packs` is able to find packs anywhere, as long as those locations are specified in `packs.yml`.
naveg
force-pushed
the
naveg/allowed-folders
branch
from
96adbd9 to
d425374
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packsis able to find packs anywhere, as long as those locations arespecified in
packs.yml.